[WIP] use IStorage everywhere, add FIXMEs for comments #26119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I thought IStorage and Storage were the same thing, because Storage didn't have the "I" needed to add it |
|
@butonic Thank you for taking this. There is also the same problem with the ICache, there are lot of code that relies on the assumption that the ICache implementation will implement the ArrayAccess interface, but that it is not always the case, or at least it should be enforced by the ICache interface. |
6fb0bc7 to
1da923b
Compare
|
Close this experimental PR ? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DeepDiver1975 @PVince81 I tried to replace all references of non OCP interfaces from \OCP\Files\Storage\IStorage ... there is a LOT wrong with the interfaces and I'll create separate PRs to clean up some of the stuff in smaller chunks, but I want to have this here for discussion.
Scrolling through the changes I now realize that \OC\Files\Storage\Storage extends \OCP\Files\Storage\IStorage and adds parameters to some of its functions. That creates a ton of broken interdependencies.
Maybe it makes more sense to start over ... I'll need to let this sink in ...