Add remove_unused_binding assist#159
Closed
CPardi wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks! I manually merged it with some nit format change. The trivia handling seems quite complex but the result change is quite good. Probably we need more convenient methods to handle it... |
Contributor
Author
|
Great thank you for taking a look and merging.
The trivia collection code at lines 83-92 ended up the same as that in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've had a go at implementing an assist to remove bindings for the
UnusedBindingliveness check described on #39. If you have time to take a look that would be great, thanks.The changes include adding a
remove_unused_bindingfunction which does the following stepsUnusedBindingis not present then returnpack_bindingsimplementation and removed the inner bindings logic to get the TextRange to delete.I have added some tests and updated the code_action.md document also.