Diagnostics CLI: return different exit code when only warnings#90
Merged
Conversation
oxalica
requested changes
Jun 9, 2023
oxalica
reviewed
Jun 9, 2023
oxalica
requested changes
Jun 9, 2023
oxalica
left a comment
Owner
There was a problem hiding this comment.
Also please squash and edit your commit messages to comply to the main branch.
Contributor
Author
|
Okay, I did the requested changes & hope the squashed commit message is good enough 😅 |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this amazing project! ❤️
Would love to be able to ignore warnings for the pre-commit hook in my devenv