bump react, react-dom and ink versions to latest #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315f252 to
d6e7236
Compare
Owner
|
The bump of Ink breaks CJS support which is why I've held off upgrading it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the dependencies for react, react-dom, and ink to their latest versions.
Motivation
The update is necessary to resolve peer dependency issues encountered when using pnpm with React version 18.3.1. This ensures compatibility and smooth installation for projects utilizing the latest React version.
Context
pnpm enforces strict peer dependency resolution. If a project uses React 18 but one of its dependencies requires React 17, pnpm will flag this as a conflict, potentially preventing successful installation. By aligning the library's dependencies with the latest React version, this PR mitigates such issues.
The ink package needs to be updated as well, as it relies on an older version of react-reconcile, which is also problematic for dependency resolution with the latest React version.