allow CSS Color Module Level 5 #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with merging this earlier than it works in browsers, since we're just "passing colors through". When it works, your second example will be very useful for dark mode (just stating the obvious). color-mix is still waiting for firefox, it seems. (For lch() I couldn't find the additional syntax on caniuse.) |
|
This looks ready — it just needs test. The lack of browser support for level 5 shouldn’t be a blocker because this is also adding support for level 4. |
0b7b5e9 to
a0bf747
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* allow CSS Color Module Level 5 * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://www.w3.org/TR/css-color-5/
Allows a variety of new ways of specifying colors, including mixing colors:
And relative colors:
Though, I can’t really seem to get the latter to work, so probably we should leave this as a draft until it works.
Fixes #1851.