index-aware reducer functions #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
May 15, 2023
|
Yes, relevant xkcd. I don’t think we can avoid backwards incompatibility entirely but this feels reasonable to me. I would expect people to specify the min (named) reducer instead of passing in d3.min directly, for example. |
|
I should have added this to the map transform, too. This should use a taker instead: Line 78 in 42f5d9f |
Merged
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* index-aware reducer functions * simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to write an interactive index chart where the user specifies the date at which to normalize series. This means I can’t use the built-in first normalize basis; I need to find the appropriate starting value for each series based on the given date. While I could do this outside of Plot, I’d prefer to implement this within the existing normalize transform, which means I want access to the index (
I) within the normalize basis method. This PR allows that, maintaining backwards compatibility by checking the length of the reduce function. This applies to both the normalize and window transforms.