pointer-events: none when not sticky #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly the tests that failed revealed a small bug in the rule mark. LGTM, we'll just have to refresh 79 snapshot tests before merging |
Fil
approved these changes
Jun 16, 2023
mbostock
commented
Jun 17, 2023
908ea63 to
439eb91
Compare
09a6637 to
6eb1c86
Compare
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
* pointer-events: none when not sticky * add missing context in call to applyIndirectStyles * regenerate snapshots * greedy context copy --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* pointer-events: none when not sticky * add missing context in call to applyIndirectStyles * regenerate snapshots * greedy context copy --------- Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pointer transform now applies pointer-events: none to the downstream mark when the pointer is not sticky.