fix symbol set hint when fill is a constant currentColor #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…still want to pass "currentColor" as a hint to the symbol scale closes #1462
mbostock
reviewed
Aug 24, 2023
|
My understanding is that fill defaults to "none", and "currentColor" for fill is transformed into null in style.js because that's the SVG default for path fill. Line 109 in 1ff36a3 but for the hint, we want to actually send an explicit fill: "currentColor" as the hint that this symbol has a fill. The logic is different for stroke, which defaults to currentColor which is not transformed into null. |
Right. But I think it’s still asymmetric. In essence, we’re trying to materialize the global default fill or stroke into the hint: if there isn’t a fill channel, nor this.fill, then we’re using the implied default fill which is currentColor. And for stroke, the implied default is none. So the logic should instead be: symbolChannel.hint = {
fill: fillChannel
? fillChannel.value === symbolChannel.value
? "color"
: "currentColor"
: this.fill ?? "currentColor",
stroke: strokeChannel
? strokeChannel.value === symbolChannel.value
? "color"
: "currentColor"
: this.stroke ?? "none"
}; |
mbostock
approved these changes
Aug 24, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
…q#1830) * when we specify fill: "currentColor", this.fill is undefined, but we still want to pass "currentColor" as a hint to the symbol scale closes observablehq#1462 * materialize default stroke, too --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we specify fill: "currentColor", this.fill is undefined, but we still want to pass "currentColor" as a hint to the symbol scale
closes #1462