Stats: type extension to distinguish NSLC and Source Identifier cases #3558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a prototype to showcase how the current
Statsobject could be modified to internally have a switch between NSLC and SourceID system. This is an alternative approach with trying to have a minimal amount of outward facing class/hierarchy changes, in comparison to changing the class structure/hierarchy like prototyped in #3550Why was it initiated? Any relevant Issues?
MiniSEED v3 uses the newly introduced FDSN Source Identifier which differs from the "traditional" NSLC (net/sta/loc/cha) way to label data.
Compare #3550
PR Checklist
masterfor new features,maintenance_...for bug fixesno_cilabel can be added to skip CI buildsJust add the
build_docstag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn) should be tested for the PR,just add the
test_networktag to this PR.CHANGELOG.txt.CONTRIBUTORS.txt.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
CODEOWNERSwith your github handleready for reviewlabel when you are ready for the PR to be reviewed.