io.ascii read dtypes, because why not (fixes #3534)#3611
Merged
ThomasLecocq merged 9 commits intomasterfrom Dec 24, 2025
Merged
io.ascii read dtypes, because why not (fixes #3534)#3611ThomasLecocq merged 9 commits intomasterfrom
ThomasLecocq merged 9 commits intomasterfrom
Conversation
Now allows the "dtype" column to be INT* or FLOAT* (startswith("INT") | startswith("FLOAT"))
Contributor
Author
|
Remaining failed tests are unrelated (shapefile). Ready ? |
Contributor
Author
|
as such, the code (and tests) don't verify that the items read can actually be casted to the right format... but yay... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io.ascii now allows the "dtype" column to be INT* or FLOAT* matching numpy dtypes.
Why was it initiated? Any relevant Issues?
fixes #3534
PR Checklist
masterfor new features,maintenance_...for bug fixesJust add the
build_docstag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
CHANGELOG.txt.ready for reviewlabel when you are ready for the PR to be reviewed.