Skip to content

Fix: Make pytorch is not a hard dependency #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2025
Merged

Fix: Make pytorch is not a hard dependency #1162

merged 2 commits into from
Jun 22, 2025

Conversation

@ducviet00
Copy link
Contributor

@ducviet00 ducviet00 commented Jun 10, 2025 •
edited
Loading

Description

I don't think torch is a hard dependency for sahi

from sahi.slicing import slice_image

  File "/usr/local/lib/python3.12/site-packages/sahi/__init__.py", line 4, in <module>
    from sahi.auto_model import AutoDetectionModel
  File "/usr/local/lib/python3.12/site-packages/sahi/auto_model.py", line 3, in <module>
    from sahi.models.base import DetectionModel
  File "/usr/local/lib/python3.12/site-packages/sahi/models/__init__.py", line 1, in <module>
    from . import base, detectron2, huggingface, mmdet, torchvision, ultralytics, yolov5, yolov8onnx
  File "/usr/local/lib/python3.12/site-packages/sahi/models/base.py", line 10, in <module>
    from sahi.utils.torch import empty_cuda_cache, has_torch, select_device
  File "/usr/local/lib/python3.12/site-packages/sahi/utils/torch.py", line 10, in <module>
    from torch import Tensor, device
ModuleNotFoundError: No module named 'torch'

@ducviet00
Copy link
Contributor Author

ducviet00 commented Jun 11, 2025

@fcakyon PTAL ❤️

@fcakyon fcakyon self-requested a review June 22, 2025 04:54
@fcakyon
Copy link
Collaborator

fcakyon commented Jun 22, 2025

@ducviet00 good point, it would be much better if slicing utils did not require pytorch, lets see if CI tests will pass 👍🏻

@fcakyon fcakyon added this pull request to the merge queue Jun 22, 2025
Merged via the queue into obss:main with commit d24f273 Jun 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcakyon fcakyon fcakyon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ducviet00 @fcakyon