Skip to content

Conversation

@mattiase
Copy link
Contributor

@mattiase mattiase commented Sep 4, 2025

Actually the compiler restricts identifiers to Latin-9 but it's a start, and I see no reason to hold back here.
(There are a couple of housekeeping patches here too. I could put them in a separate PR if you like.)

@monnier
Copy link
Contributor

monnier commented Sep 4, 2025

The CI doesn't seem happy, but other than that it looks OK to me. Can you point to the OCaml doc specifying the Unicode support? Is it possible to use UTF-8 encoding?

@mattiase
Copy link
Contributor Author

mattiase commented Sep 4, 2025

It's new in OCaml 5.3.0; see the language manual and ocaml/ocaml#11736, ocaml/ocaml#12664, ocaml/ocaml#13628. I've verified that the CI grumpiness is nothing that wasn't there before (we really should do something about that).

To editorialise a bit, I think Unicode identifiers is an underrated feature, especially for teaching: any cognitive barriers removed for your students helps, even at uni+ level. I hope it can be extended to more scripts, even unicameral ones with some effort.

@mattiase
Copy link
Contributor Author

mattiase commented Sep 4, 2025

To be clear, the encoding is always UTF-8.

@monnier
Copy link
Contributor

monnier commented Sep 4, 2025

Cool. I hadn't paid attention to the changes from latin-1 eons ago. 👍

@mattiase
Copy link
Contributor Author

mattiase commented Sep 9, 2025

Anything left to do? I can't push this myself.
The CI errors are unrelated (from 10bfb61, see #317).

@monnier monnier merged commit de9572f into ocaml:master Sep 9, 2025
0 of 6 checks passed
@monnier
Copy link
Contributor

monnier commented Sep 9, 2025 via email

@mattiase mattiase deleted the unicode-ident branch September 9, 2025 16:06
@mattiase
Copy link
Contributor Author

Thank you. Push the CHANGES.md part (#324) too? I forgot we maintained that file as well.

@monnier
Copy link
Contributor

monnier commented Sep 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants