Raw.Util module CPP #163
Merged
Raw.Util module CPP #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, sounds like a sensible addition! Could you rebase? |
Provides combinators for extracting fields from Yojson.Raw values. Matches the API for Yojson.Basic.Util and Yojson.Safe.Util.
Contributor
Author
|
I've rebased @Leonidas-from-XIV the CI failure is caused by ocamlformat not handling CPP files. |
Leonidas-from-XIV
approved these changes
Apr 4, 2023
Member
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Apr 26, 2023
CHANGES: *2023-04-26* ### Added - Add `Yojson.Raw.Util` module to provide combinators for extracting fields from `Yojson.Raw.t` values. (@tmcgilchrist, ocaml-community/yojson#163) - Add `Util.path` function to recurse into an object through a list of keys. (@cuihtlauac, @Leonidas-from-XIV, ocaml-community/yojson#157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #96