Differentiate between user systems and dependencies#131
Draft
dieggsy wants to merge 2 commits into
Draft
Conversation
- Executable sets systems explicitly listed on the command line as user-installed - Runtime hooks into ASDF's load operation and looks for systems in an ocicl directory that are depended on by a system outside an ocicl directory, setting those as user-installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be required for #122 and #119, which could be implemented in this same pull request.
ociclexecutable sets top level systems directly installed via command line as user-installedOne issue I have is that the way the ocicl-runtime achieves this is by defining an :around method for asdf's default load-op, which feels... pretty icky. In particular because, per the ASDF manual:
We can define custom operations, but they won't be called by default. We could define a subclass of
asdf:system, but systems would have to specify our class in the system definition. So I'm not sure how else we'd do this in the runtime. I would welcome any ideas that don't involve comandeering load-op like this, though. Maybe it's okay if it's just well-documented?