Fix a crash when switching to different texture format with RendererHasTextures as false. #8824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ImFontAtlasBuildMainfor a second time with a different desired texture format, using theStbTruetypefont loader, andatlas->RendererHasTexturesbeingfalse, a crash occurs due tobd_font_databeingnullptr.This is seemingly because
ImGui_ImplStbTrueType_FontSrcDestroysetssrc->FontLoaderDatatonullptr, and this member is then accessed in the callstack:The logic to handle a different desired texture format is already doing most of what
ImFontAtlasBuildCleardoes, and just calling that includes calls to ImFontAtlasFontSourceInit which fixes the crash issue by initializingsrc->FontLoaderData.