fix: return a promise from yeoman callback style so it actually awaits #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@amphro I would do this on your behalf but I don't think I can. Can you rename the commit message to "fix: return a promise from yomen callback style so it actually awaits". This way it will go into the changelog correctly |
Contributor
Author
|
@jdxcode doesn't seem to like that one either |
Contributor
|
it's fine, I was toying with git cop to make it clearer but it doesn't really work right |
oclif-bot
pushed a commit
to oclif/example-single-js
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
to oclif/example-single-ts
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
to oclif/example-plugin-js
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
to oclif/example-plugin-ts
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
to oclif/example-multi-js
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
to oclif/example-multi-ts
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([c22f423](oclif/oclif@c22f423))
oclif-bot
pushed a commit
that referenced
this pull request
Mar 15, 2018
<a name="1.3.10"></a> ## [1.3.10](bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](#43)) ([c22f423](c22f423))
JaeBradle
pushed a commit
to JaeBradle/oclif
that referenced
this pull request
Oct 19, 2022
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@8771b95...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([#43](oclif/oclif#43)) ([32be2c5](oclif/oclif@32be2c5))
gaelmotte
pushed a commit
to gaelmotte/oclif
that referenced
this pull request
Oct 24, 2022
gaelmotte
pushed a commit
to gaelmotte/oclif
that referenced
this pull request
Oct 24, 2022
<a name="1.3.10"></a> ## [1.3.10](oclif/oclif@bbea1b6...v1.3.10) (2018-03-15) ### Bug Fixes * return a promise from yeoman callback style so it actually awaits ([oclif#43](oclif#43)) ([c22f423](oclif@c22f423))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeomans env.run doesn't seem to return a promise, but takes a callback.