[IMP] build: skip sibling type builds when building owl.d.ts#1869
Merged
Conversation
The root build:types ran dts-bundle-generator four times: once per sibling package (owl-core, owl-compiler, owl-runtime), then once on the umbrella owl package. Only @odoo/owl is published, and the umbrella bundle inlines the sibling types anyway, so the three sibling passes were wasted work — ~22s of a ~31s wall clock. Point the umbrella's dts-bundle-generator at sibling src via tsconfig paths (the same mapping tsconfig.tests.json already uses) and drop the sibling build:types steps from the root script. To keep the generated owl.d.ts byte-identical, promote four internal aliases from owl-core/types.ts (Constructor, LiteralTypes, ResolveOptionalEntries, UnionToIntersection) to exports — without them dts-bundle-generator inlines their expansions instead of keeping the named references. build:types now runs in ~9s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root build:types ran dts-bundle-generator four times: once per sibling package (owl-core, owl-compiler, owl-runtime), then once on the umbrella owl package. Only @odoo/owl is published, and the umbrella bundle inlines the sibling types anyway, so the three sibling passes were wasted work — ~22s of a ~31s wall clock.
Point the umbrella's dts-bundle-generator at sibling src via tsconfig paths (the same mapping tsconfig.tests.json already uses) and drop the sibling build:types steps from the root script. To keep the generated owl.d.ts byte-identical, promote four internal aliases from owl-core/types.ts (Constructor, LiteralTypes, ResolveOptionalEntries, UnionToIntersection) to exports — without them dts-bundle-generator inlines their expansions instead of keeping the named references.
build:types now runs in ~9s.