[IMP] reactivity: rename signal.invalidate to signal.trigger#1871
Merged
Conversation
85fcf42 to
971e859
Compare
The name "invalidate" described the internal effect rather than the user's intent; "trigger" makes the API clearer at the call site when manually notifying subscribers after an in-place mutation. Mirrors Vue's triggerRef. closes #1870
scope.ts only re-exported symbols from owl-core. Pull the public surface directly from owl-core in index.ts, and have internal modules import from owl-core as well.
Two related sources of noise when an error bubbled out unhandled: 1. As the throw unwound through each ancestor's render catch block, handleError was re-entered at every component level — each frame finalizing again and wrapping the already-wrapped OwlError, producing nested "Caused by: [Owl] Unhandled error" chains proportional to component depth. 2. Even a single-level wrap added little value when the underlying error was already an OwlError (e.g. invalid props, missing component, template compile failure) — the inner message already identifies the failure. Mark the App as destroyed in destroy(), short-circuit handleError / forwardErrorToParent on re-entry so the propagating error is not re-handled, and skip the "Unhandled error. Destroying the root component" wrapper when the error is already an OwlError. Non-OwlErrors (TypeError, etc.) still get wrapped so the user sees that the app was destroyed.
971e859 to
10744ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name "invalidate" described the internal effect rather than the user's intent; "trigger" makes the API clearer at the call site when manually notifying subscribers after an in-place mutation.
closes #1870