Skip to content

Replace print in precalc by logging#125

Merged
jnettels merged 5 commits into
devfrom
Fix/Replace_print_in_precalc
Oct 23, 2023
Merged

Replace print in precalc by logging#125
jnettels merged 5 commits into
devfrom
Fix/Replace_print_in_precalc

Conversation

@joroeder

Copy link
Copy Markdown
Member

There are print statements in the hydraulic pre calculation. This PR replaces them by logging.info.

@jnettels jnettels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the usage of the logging function, but in my opinion it could be improved even further, by creating a logger first and then calling logger.info().
See my note about that in #129.

Cheers

Comment thread dhnx/optimization/precalc_hydraulic.py Outdated
Comment thread dhnx/optimization/precalc_hydraulic.py Outdated
Comment thread dhnx/optimization/precalc_hydraulic.py Outdated
Comment thread dhnx/optimization/precalc_hydraulic.py Outdated
@jnettels jnettels merged commit a66d25c into dev Oct 23, 2023
@jnettels jnettels deleted the Fix/Replace_print_in_precalc branch October 23, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants