Docs/grid icons#1168
Merged
Merged
Conversation
Bachibouzouk
approved these changes
Mar 2, 2025
Bachibouzouk
left a comment
Contributor
There was a problem hiding this comment.
The comments in the two python files are in german, it is intentional?
Apart from this I would say it is good to merge
| esgr = ESGraphRenderer( | ||
| energysystem_model, | ||
| legend=False, | ||
| filepath="D:/ES.svg", |
Contributor
There was a problem hiding this comment.
Suggested change
| filepath="D:/ES.svg", | |
| filepath="ES.svg", |
The example with D:/ will only work for windows users and for windows users having a drive under this address.
| @@ -0,0 +1,285 @@ | |||
| import matplotlib.colors as mcolors | |||
Contributor
There was a problem hiding this comment.
A docstring to this module would be helpful. As far as I understood it is generating figures of the doc, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid icons are now matching to the articles. Alls light mode icons are there now. But the ones for the ldark mode which need oemof.visio are still not there (waiting for some ajustments in visio)