Remove GenericStorageBlock.init_content#1180
Merged
Merged
Conversation
The variable should have been removed, we use m.TIMESTEPS.at(1) instead.
Having more time points than time steps (last commit) also increases the number on non-zeros. Forgot to adjust that.
Contributor
|
All changes are sensible and look alright to me. |
maltefritz
approved these changes
Mar 24, 2025
maltefritz
left a comment
Contributor
There was a problem hiding this comment.
I am not able to assess the TSAM part as I haven't dealt with it yet. However, it seems coherent to me. The rest looks great and makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason,
GenericStorageBlock.init_contentwas still defined and (half way) used in some cases. This removes it, as we (should) just useGenericStorageBlock.storage_content[n, m.TIMESTEPS.at(1)instead.Fixes #1176.