Skip to content

Conversation

@kanarus
Copy link
Member

@kanarus kanarus commented Aug 29, 2025


This PR adds __rt_threaded__ internal feature flag and changes fang::bound to:

  • SendSyncOnNative -> SendSyncOnThreaded
  • SendOnNative -> SendOnThreaded
  • SendOnNativeFuture -> SendOnThreadedFuture

for fangs system to correctly handle thread-per-core async runtimes including glommio: __rt_threaded__ is activated by

  • rt_tokio
  • rt_smol
  • rt_nio
  • rt_lambda

and not activated by

  • rt_glommio
  • rt_worker

Additionally, removing an wrong debug assertion in ohkami::sync::CtrlC::new: assert_eq!(index, WAKERS.read().unwrap().len());.
(There just the amount number of them matters, not the index order. This assertion will cause some panics in thread-per-core runtimes)

@kanarus kanarus added fix Fix a bug feat Add a new feature T-fangs T-runtime labels Aug 29, 2025
github-actions[bot]
github-actions bot previously approved these changes Aug 29, 2025
@kanarus kanarus merged commit 09f5b6d into main Aug 29, 2025
9 checks passed
@kanarus kanarus deleted the fix/glommio-usability branch August 29, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Add a new feature fix Fix a bug T-fangs T-runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glommio: spawn_blocking is not usable

2 participants