fix(fangs): correctly handle thread-per-core runtime like glommio #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
__rt_threaded__internal feature flag and changes fang::bound to:SendSyncOnNative->SendSyncOnThreadedSendOnNative->SendOnThreadedSendOnNativeFuture->SendOnThreadedFuturefor fangs system to correctly handle thread-per-core async runtimes including
glommio:__rt_threaded__is activated byrt_tokiort_smolrt_niort_lambdaand not activated by
rt_glommiort_workerAdditionally, removing an wrong debug assertion in
ohkami::sync::CtrlC::new:assert_eq!(index, WAKERS.read().unwrap().len());.(There just the amount number of them matters, not the index order. This assertion will cause some panics in thread-per-core runtimes)