Skip to content

feat: add explicit fuzzy matching errors #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
okian wants to merge 1 commit into
base: wip
Choose a base branch
from
Open

feat: add explicit fuzzy matching errors #392

okian wants to merge 1 commit into from

Conversation

@okian
Copy link
Owner

@okian okian commented Aug 21, 2025

Summary

  • add FuzzyError for invalid length and overlong inputs
  • return Result from fuzzy matching APIs instead of panicking
  • expand tests for fuzzy failure cases and fix minor clippy lints

Testing

  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test --features "parallel waveform-cache" (fails: complex_mul_large_magnitude)

https://chatgpt.com/codex/tasks/task_e_68a7880c1c24832ba3f955d285e5689a

Copilot AI review requested due to automatic review settings August 21, 2025 21:26
@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/introduce-fuzzyerror-enum-and-update-functions
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copilot AI reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the fuzzy matching module by introducing proper error handling instead of panicking on invalid inputs. It adds a FuzzyError enum to handle cases like invalid pattern lengths and inputs that exceed size limits, converting all fuzzy matching APIs to return Result types.

  • Add FuzzyError enum with InvalidLength and InputTooLong variants
  • Convert fuzzy matching functions to return Result<T, FuzzyError> instead of panicking
  • Expand test coverage for error conditions and update existing tests to handle new Result types

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/fuzzy.rs Add FuzzyError enum and convert fuzzy matching APIs to return Results
tests/fuzzy_match.rs Update tests to unwrap Results from fuzzy matching functions
tests/fuzzy_alloc.rs Update allocation tests to handle new Result-based APIs
tests/resample.rs Remove extra blank lines (formatting cleanup)
tests/num.rs Remove unused Complex import
src/stft.rs Remove unused FftStrategy import in test configuration
src/num.rs Improve ComplexVec to Vec conversion efficiency
src/wavelet.rs Add dead_code allowances for unused type aliases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@okian