Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Improving API responses #27

Description

@calvintam236

As I am working on the client-side UI, I think there are few improvements can be done on API for developer use.

/api/pools

  1. Instead of providing "coin": { "type": 5 },, give the coin symbol instead. In this case, it is XMR. It is not friendly for integrations.
  2. "payoutScheme": 1,, which is better to give PPLNS. same problem as above
  3. networkHashRate, poolHashRate unit? H/s? kH/s? MH/s?
  4. It is weird to put poolFeePercent, donationsPercent inside poolStats. I think they belongs to paymentProcessing or a brand new item.
  5. lifetime pool shares received/ blocks founds?

The API should avoid hardcoding definitions into the UI, especially UI shouldn't need to update their coding once MiningCore added new coinType/ changed coinType numerical value.

/api/pool/{poolid}/stats/hourly

  1. is it possible to provide the networkHashRate, connectedMiners as well?
  2. same as 3.

/api/pool/{poolid}/blocks

  1. what is status here? same problem as above

/api/pool/{poolid}/payments

  1. same as 1.

Other issue:

  1. there isn't an endpoint for miner list.
  2. miner minute stats

I will continue update this issue while I am implementing the UI.

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions