add word wrapping for lines which are longer than the terminal width #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
approved these changes
Sep 19, 2023
BruceMacD
approved these changes
Sep 20, 2023
Contributor
BruceMacD
left a comment
There was a problem hiding this comment.
Looks good, my only suggestions is comments that explain what is going on
BruceMacD
reviewed
Sep 20, 2023
| if wrapTerm { | ||
| for _, ch := range response.Response { | ||
| if currentLineLength+1 > termWidth-5 { | ||
| // backtrack the length of the last word and clear to the end of the line |
Contributor
There was a problem hiding this comment.
Suggested change
| // backtrack the length of the last word and clear to the end of the line | |
| // backtrack the length of the last word and clear to the end of the line | |
| // \x1b[%dD: This ANSI escape code moves the cursor backward by the specified number of characters (in this case, len(wordBuffer)). | |
| // \x1b[K: This ANSI escape code clears the line from the cursor to the end. |
jmorganca
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so the REPL will properly wrap a line on a word boundary. The way it works is that it walks through each character of each token returned by the server, and then keeps a buffer of the last word. If the maximum boundary length is exceeded, it will backtrack using ANSI escape codes to the length of the current word buffer, erase to the end of the line, give a line feed, and then add the word fragment to the new line. This requires that the terminal allow ANSI graphics which should be OK for any modern terminal. If you run this headless, it will default to not wrapping any lines.
Right now I've set the width to 5 characters less than the terminal width, but we can potentially make this a setting in the future.
This fixes issue #150