mlx: refined model push behavior#15431
Merged
Merged
Conversation
dongluochen
reviewed
May 4, 2026
Contributor
|
LGTM. Please resolve conflicts. |
dongluochen
approved these changes
May 8, 2026
Refine the algorithm for parallel push of safetensors based models to get better reliability and throughput.
pdevine
reviewed
May 8, 2026
Contributor
pdevine
left a comment
There was a problem hiding this comment.
Overall looks fine, just some suggestions for naming/comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine the algorithm for parallel push of safetensors based models to get better reliability and throughput.
This reduces the default parallelism for pull and push for safetensor models to 4 so we put less burden on slow networks/routers. There is now an env var to adjust the server default.