This repository was archived by the owner on Jan 2, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 2, 2026. It is now read-only.
Empty future list after undoing action #103
Description
there is an empty future list in my app's state after i triggered unto action. I can't figure out what caused this.
Following is my configuration:
createStore(undoable(reducer, {
limit: 20,
filter: (action) => {
return undoableActions.indexOf(action) !== -1;
},
undoType: EDITPANEL_UNDO,
redoType: EDITPANEL_REDO,
initTypes: ['@@redux-undo/INIT'],
debug: true,
}), UIBuilderState.get(stateKey), applyMiddleware(thunk));
Did I do something wrong?
Activity
omnidan commentedon Jul 29, 2016
@imlgm could you provide a small example repo to make it easier to reproduce and fix this issue? something similar to this: https://github.com/peteruithoven/redux-undo-filtering-issue-example would be perfect 😁
imlgm commentedon Aug 10, 2016
@omnidan OK, I will try,
Because the project I run is a little complicated, and the project also used some private package. I am not sure whether I can reproduce the bug if I set up a new demo project.
davidroeca commentedon Dec 14, 2016
I've fixed this in the following pull request: #139
The problem in your case is that the present is filtered, and the old logic didn't allow for any state to be saved in the past or present if wasFiltered was true. My change removes wasFiltered in favor of a copy of the state from the most recent unfiltered action, which gets updated every insert, undo, redo, or jump
Merge pull request #139 from davidroeca/master
omnidan commentedon Dec 20, 2016
I published a new version
beta9-3that should fix this issue (thanks a lot, @davidroeca 🎉)Let me know if it works now and feel free to reopen if you're still having issues! 😁