Skip to content

Add monorepo ESLint/Prettier baseline and CI fail-fast checks#28

Merged
onevcat merged 3 commits into
masterfrom
feat/issue-22-eslint-prettier-ci
Apr 11, 2026
Merged

Add monorepo ESLint/Prettier baseline and CI fail-fast checks#28
onevcat merged 3 commits into
masterfrom
feat/issue-22-eslint-prettier-ci

Conversation

@onevcat

@onevcat onevcat commented Apr 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • add root eslint.config.mjs using flat config with @typescript-eslint/recommended and eslint-config-prettier
  • add root Prettier config (tabWidth: 2, useTabs: false, semi: true, singleQuote: false, trailingComma: "none", printWidth: 120) and .prettierignore
  • add root scripts: lint, format, format:check
  • add ESLint/Prettier dev dependencies at workspace root and update lockfile
  • update CI to run npm run lint and npm run format:check right after npm ci (before check/test/build) for fail-fast
  • run one baseline formatting pass so format:check is green from this PR onward

Scope Notes

  • intentionally excludes runtime/CLI follow-up topics discussed separately (c1-c4)
  • intentionally does not introduce lint-staged/husky in this initial PR

Validation

  • npm run format:check
  • npm run lint
  • npm run check
  • npm run test
  • npm run build

Closes #22

@onevcat

onevcat commented Apr 11, 2026

Copy link
Copy Markdown
Owner Author

@onevclaw 解一下冲突，可以考虑把相关变更rebase到最新的master上，然后再跑一次lint应该就行。本地配一下lint环境，看看最新的run为什么失败了，修好了再推上来

@onevcat onevcat force-pushed the feat/issue-22-eslint-prettier-ci branch from 448903a to 3da0cad Compare April 11, 2026 01:59
@onevclaw

onevclaw commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

已处理完成：

  • 已将 feat/issue-22-eslint-prettier-ci rebase 到最新 master，并解决冲突。
  • 最新失败 run 的根因是 rebase 冲突后 packages/argue-cli/src/runtime/delegate.ts 中 createApiRunner 调用参数被回退成旧签名，导致 npm run check 报错：TS2554 Expected 2 arguments, but got 1。
  • 已修复调用签名并补齐冲突后的格式化差异，重新执行并通过：npm run lint、npm run format:check、npm run check、npm run test、npm run build。
  • 已推送更新到同一分支（force-with-lease）。
  • 新 CI run 已通过：https://github.com/onevcat/argue/actions/runs/24272081841

🧵 mh_1775872469982_625fdb50 · 🐾 main → main
🪝 gh:onevcat:argue:pr:28:main:m202604
🆔 92b66746-1a57-4674-bd12-a94a79fd282a

@onevcat onevcat merged commit 58b4abf into master Apr 11, 2026
1 check passed
@onevcat onevcat deleted the feat/issue-22-eslint-prettier-ci branch April 11, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ESLint and Prettier configuration

2 participants

@onevcat @onevclaw