Register nodes with PoP #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #457 into the
ledger-app-flowbranch.ledger-app-flowtracks the version of transaction scripts released on the Flow app on Ledger wallets: https://github.com/LedgerHQ/app-flow. At the point of this PR, the Flow app released version isv0.14.0.This PR only applies the PoP changes on top of
ledger-app-flow. Including all the other changes frommasterinto the future Ledger release is beyond the scope of the PoP changes, it delays the Ledger review of the PoP work, and makes the testing scope larger.