Skip to content

Add GinkgoLogr#1067

Merged
onsi merged 2 commits into
onsi:masterfrom
Nuckal777:logr
Oct 23, 2022
Merged

Add GinkgoLogr#1067
onsi merged 2 commits into
onsi:masterfrom
Nuckal777:logr

Conversation

@Nuckal777

Copy link
Copy Markdown
Contributor

Resolves #1063 .

@onsi

onsi commented Oct 21, 2022

Copy link
Copy Markdown
Owner

hey there this looks good. can you also update the docs (probably here is best: https://github.com/onsi/ginkgo/blob/master/docs/index.md#logging-output)

to mention GinkgoLogr?

Thanks!

@onsi

onsi commented Oct 23, 2022

Copy link
Copy Markdown
Owner

Looks good - thanks!

@onsi onsi merged commit bf78c28 into onsi:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement logr.LogSink for GingkoWriter

2 participants