Skip to content

Add GinkgoTB() function#1333

Merged
onsi merged 1 commit into
onsi:masterfrom
TenKeyLabs:eb/add-ginkgo-tb
Jan 9, 2024
Merged

Add GinkgoTB() function#1333
onsi merged 1 commit into
onsi:masterfrom
TenKeyLabs:eb/add-ginkgo-tb

Conversation

@ebabani

@ebabani ebabani commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

This function returns a wrapper around GinkgoT() which satisfies the testing.TB interface.

  • Update fail tests with tests for GinkgoT() and GinkgoTB().
  • Fix a bug where GinkgoT().Fail() was not reporting the correct line on error.

@onsi

onsi commented Jan 8, 2024

Copy link
Copy Markdown
Owner

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

This function returns a wrapper around GinkgoT() which satisfies the `testing.TB` interface.

- Update fail tests with tests for GinkgoT() and GinkgoTB().
- Fix a bug where GinkgoT().Fail() was not reporting the correct line on error.
@ebabani

ebabani commented Jan 8, 2024

Copy link
Copy Markdown
Contributor Author

thanks! this looks great - but I think there’s a bug in the (previous, existing) test that checks that all definitions in the core DSL are exported in the modular DSL package (long story….). I’ll take a look later today/tomorrow and fix it.

I pushed a fix for that failure. Forgot to run those tests and was only running integration tests.

I updated the symbol check to ignore functions with a receiver. Those methods are never going to cause an import conflict, and I added the missing package level functions and types to core_dsl.go.

@onsi onsi merged commit 92b6744 into onsi:master Jan 9, 2024
@onsi

onsi commented Jan 9, 2024

Copy link
Copy Markdown
Owner

fantastic, thank you! i’ll cut a release soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants