add books package for example#568
Merged
Merged
Conversation
Collaborator
|
Hi @jianzhangbjz. Sorry that it's taken so long to review this. I agree that having an examples is always helpful, and hopefully your work will help other people to learn Ginkgo. |
Contributor
Author
|
@blgm sorry for the late reply, yes, I agreed, thank you very much! |
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I following this adding-specs-to-a-suite to practice the Ginkgo. I found no
bookspackage as a sample. So, I add it, but I haven't add all the functions for it. I draft this PR for discussing it. Comments are welcome!