Skip to content

Fix missing newline in combined coverage file#641

Merged
blgm merged 1 commit into
onsi:masterfrom
diafour:patch-1
Mar 15, 2020
Merged

Fix missing newline in combined coverage file#641
blgm merged 1 commit into
onsi:masterfrom
diafour:patch-1

Conversation

@diafour

@diafour diafour commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Hi! It is a slight improvement of #552. Sometimes the coverage file has no newline in the end and the combined report is not usable:

mode: atomic
...
github.com/flant/shell-operator/test/utils/shell-operator.go:109.99,111.2 1 0
github.com/flant/shell-operator/test/utils/shell-operator.go:113.106,115.2 1 0github.com/flant/shell-operator/test/utils/kind-k8s-cluster.go:16.50,24.16 4 1
github.com/flant/shell-operator/test/utils/kind-k8s-cluster.go:27.2,27.17 1 1
...

Error: open github.com/flant/shell-operator/test/utils/shell-operator.go:113.106,115.2 1 0github.com/flant/shell-operator/test/utils/kind-k8s-cluster.go:16.50,24.16 4 1: no such file or directory
Usage:
  cc-test-reporter format-coverage [coverage file] [flags]

@blgm blgm merged commit 6a07ea2 into onsi:master Mar 15, 2020
@blgm

blgm commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator

Thank you @diafour!

@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diafour @blgm