Print correct code location of failing table test#666
Merged
Conversation
Collaborator
|
I think I'm ok with |
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #515 and #635 for motivation.
Given a test file
Output before this PR:
Output after this PR:
Running Suite: Tabletests Suite =============================== Random Seed: 1587237050 Will run 3 of 3 specs • ------------------------------ • Failure [0.000 seconds] Bar /Users/david/scratch/tabletests/bar_test.go:9 table /Users/david/scratch/tabletests/bar_test.go:10 yolo2 [It] /Users/david/scratch/tabletests/bar_test.go:15 Expected <int>: 1 to equal <int>: 0 /Users/david/scratch/tabletests/bar_test.go:12 ------------------------------ • Failure [0.000 seconds] Bar /Users/david/scratch/tabletests/bar_test.go:9 table /Users/david/scratch/tabletests/bar_test.go:10 yolo3 [It] /Users/david/scratch/tabletests/bar_test.go:10 Expected <int>: 1 to equal <int>: 0 /Users/david/scratch/tabletests/bar_test.go:12 ------------------------------Notes:
TableEntrydirectly instead of using one of the(F/P/X)Entryconstructors (as done in theyolo3example above), the code location of the failingTableEntrydefaults to the surroundingDescribeTablesince I didn't find a way to programmatically locate theTableEntry. If someone has a good idea, let me know.TableEntrydirectly (most users use the(F/P/X)Entryconstructors), the changes in here are backwards compatible if the users use aTableEntrycomposite literal with keyed fields. If however, users use aTableEntrywith unkeyed fields (i.e. something likeTableEntry{"yolo3", []interface{}{1}, false, false}), the changes in this PR will break them. In that case, they would need to name the fields or use the(F/P/X)Entryconstructors.