Rework handling of IRI creation based on CURIE/label #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #688
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis PR is mainly to add better error-handling to IRI resolution in
template. If a prefix was not defined, a CURIE could still get passed as an "IRI", but the ontology would fail to save because it wasn't a valid QName. All entities generated from templates should have IRIs that are valid QNames, otherwisetemplatewill fail at the very end withIllegalElementNameException.The template tests had to be updated because it turned out that the third template we were testing for the "multiple templates" had everything in it (IDs from
template-ids.csvand synonyms fromtemplate-labels.csv), so the first two didn't really matter. Additionally, we were never passing the previously generated ontology as input. For example, if you define labels and IDs intemplate-ids.csvand use only labels intemplate.csv, it would fail. It didn't fail in the past because we included an ID column intemplate.csv. This is just a minor rework of the test, not an issue with the template operation.