Fix how Template adds entities to the QuotedEntityChecker #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not really a cycle but a sequence path. |
Contributor
Author
|
I think the problem is that: If there is no labels column, Template.addLabels() never adds anything to the |
|
Thank you, Nico! You said in Slack that adding column |
Contributor
Author
|
Thanks for confirming. It's still important for us to get to the bottom of this! |
Member
|
Please reopen if you still want this PR. |
matentzn
commented
Nov 29, 2023
Contributor
Author
matentzn
left a comment
There was a problem hiding this comment.
@jamesaoverton looked through your changes, made some small comments for sanity checking but most likely everything is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Updated by @jamesaoverton)
Resolves #1133, resolves #1156.
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedReplaces private
Template.addLabels()withTemplate.addEntities(): for each row in the template, make sure to add an entity to the QuotedEntityChecker (QEC). The previous version skipped rows without a LABEL. The new version adds both the label (if present) and the ID to the QEC. I believe this is backwards compatible.I had problems with CI that seem unrelated, so I also dropped a test for subset extraction. See #1166.