Feat/render previews #4885

pablonyx · 2025-06-12T22:30:49Z

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

This PR should be backported (make sure to check that the backport attempt succeeds)
[Optional] Override Linear Check

- Add railway.json for Railway deployment config - Add docker-compose.railway.yml with non-privileged Vespa - Add GitHub workflow for automatic PR deployments - Add nginx config for preview environments - Add setup documentation This enables automatic preview environments for each PR with full Onyx stack

- Add render.yaml for Render Blueprint configuration - Configure compose-based deployment with docker-compose.railway.yml - Set up standard-16 plan (16GB/4vCPU) for preview environments - Add GitHub workflow to deploy preview environments on PR events - Expose port 80 publicly for nginx proxy 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

vercel · 2025-06-12T22:30:53Z

@pablonyx is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

greptile-apps

PR Summary

Added comprehensive preview environment infrastructure across multiple platforms (Railway and Render) with associated configuration and workflow files for automated PR deployments.

New .github/workflows/preview-deploy.yml and .github/workflows/render-preview.yml automate preview environment creation, but should address security considerations around API key usage
Added deployment/docker_compose/docker-compose.railway.yml with reduced resource limits and simplified configurations, though requiring security hardening
Introduced deployment/docker_compose/nginx-preview.conf with streamlined configurations (100M body size vs 5G in production)
Added platform-specific configs (render.yaml, railway.json) for containerized preview deployments with auto-generated credentials
New deployment/railway-setup.md provides detailed documentation for setting up PR-specific preview deployments

_{7 files reviewed, 7 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-12T22:31:23Z

deployment/docker_compose/nginx-preview.conf

+        # Increase client body size for file uploads
+        client_max_body_size 100M;


logic: client_max_body_size is set to 100M while production uses 5G. This significant difference could cause file upload issues in preview environments.

greptile-apps · 2025-06-12T22:31:24Z

.github/workflows/render-preview.yml

+  deploy-preview:
+    runs-on: ubuntu-latest
+    steps:


logic: Missing checkout step before deployment. Need 'actions/checkout@v4' to access repository files.

greptile-apps · 2025-06-12T22:31:25Z

deployment/docker_compose/docker-compose.railway.yml

+    healthcheck:
+      test: ["CMD", "curl", "-f", "http://localhost:8080/api/health"]
+      interval: 30s
+      timeout: 10s
+      retries: 3


logic: API healthcheck is using port 8080 which may conflict with Vespa using the same port (line 101). Consider using different ports or configuring a proxy.

greptile-apps · 2025-06-12T22:31:26Z

.github/workflows/preview-deploy.yml

+name: Deploy Preview Environment
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]


logic: Missing 'closed' event type in pull_request triggers, but cleanup-preview job depends on it.

Suggested change

name: Deploy Preview Environment

on:

pull_request:

types: [opened, synchronize, reopened]

name: Deploy Preview Environment

on:

pull_request:

types: [opened, synchronize, reopened, closed]

greptile-apps · 2025-06-12T22:31:28Z

render.yaml

+      - key: RAILWAY_PUBLIC_DOMAIN
+        fromService:
+          type: compose
+          name: onyx-preview
+          property: hostport


logic: RAILWAY_PUBLIC_DOMAIN is using a circular reference - the service is referencing itself for the hostport property

greptile-apps · 2025-06-12T22:31:30Z

railway.json

+    "dockerfilePath": "deployment/docker_compose/docker-compose.railway.yml"
+  },
+  "deploy": {
+    "startCommand": "docker-compose -f deployment/docker_compose/docker-compose.railway.yml up",


logic: docker-compose up without -d will run in foreground and may cause Railway to think the deployment failed when output stops. Use docker-compose -f deployment/docker_compose/docker-compose.railway.yml up -d

greptile-apps · 2025-06-12T22:31:31Z

railway.json

+    "builder": "DOCKERFILE",
+    "dockerfilePath": "deployment/docker_compose/docker-compose.railway.yml"


logic: dockerfilePath points to a docker-compose.yml file but builder is set to DOCKERFILE. Should use NIXPACKS or specify the correct Dockerfile path

- Simplify render.yaml to minimal configuration - Add previews.generation: automatic - Fix GitHub action name to preview-environment-action (singular) - Add checkout step to workflow - Remove unnecessary configuration options

- Delete .github/workflows/render-preview.yml - Render will automatically create preview environments with just render.yaml - No GitHub Action needed when previews.generation: automatic is set

- Remove substring() function call which is not supported in GitHub Actions expressions - Display full commit SHA instead of shortened version

- Updated render.yaml to use docker-compose.prod-cloud.yml - Added GitHub workflow for automatic preview environment creation - Configured all services with appropriate environment variables - Set up compose service with standard-16 plan (4 vCPU / 16 GB) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

pablonyx · 2025-06-12T23:47:13Z

🚀 Updated Render Preview Configuration

I've updated the configuration to properly support Render Preview Environments:

Changes Made:

✅ Fixed render.yaml to use the correct docker-compose file (docker-compose.prod-cloud.yml)
✅ Added comprehensive environment variables for all services
✅ Created the GitHub workflow file at .github/workflows/render-preview.yml

⚠️ Required Setup:

To enable preview environments, you need to add the RENDER_API_KEY secret:

Get your Render API key:
- Go to https://dashboard.render.com/u/settings
- Navigate to API Keys section
- Create a new API key
Add to GitHub repository:
- Go to repository Settings → Secrets and variables → Actions
- Click "New repository secret"
- Name: RENDER_API_KEY
- Value: Your Render API key

How It Works:

Every PR will automatically create an isolated preview environment
The environment includes all services: API, web server, PostgreSQL, Redis, Vespa, etc.
Preview URLs will be posted as PR comments
Environments are automatically destroyed when PRs are closed/merged

Resources:

Once the RENDER_API_KEY is added, new PRs will automatically get preview environments! 🎉

The preview-deploy.yml workflow was using Railway commands but we need Render preview environments instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Render automatically creates preview environments when: 1. A render.yaml exists with previewEnv: true 2. The repository is connected to Render No GitHub workflow is needed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

pablonyx and others added 2 commits June 12, 2025 10:04

pablonyx requested a review from a team as a code owner June 12, 2025 22:30

greptile-apps bot reviewed Jun 12, 2025

View reviewed changes

pablonyx and others added 4 commits June 12, 2025 15:33

Fix Render configuration based on feedback

0ce29a8

- Simplify render.yaml to minimal configuration - Add previews.generation: automatic - Fix GitHub action name to preview-environment-action (singular) - Add checkout step to workflow - Remove unnecessary configuration options

Remove GitHub workflow - Render handles previews automatically

b9e29f7

- Delete .github/workflows/render-preview.yml - Render will automatically create preview environments with just render.yaml - No GitHub Action needed when previews.generation: automatic is set

Fix preview-deploy.yml syntax error

b344304

- Remove substring() function call which is not supported in GitHub Actions expressions - Display full commit SHA instead of shortened version

pablonyx and others added 2 commits June 12, 2025 16:48

Remove conflicting Railway workflow

8d4d894

The preview-deploy.yml workflow was using Railway commands but we need Render preview environments instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

wenxi-onyx closed this Jul 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/render previews #4885

Feat/render previews #4885

Uh oh!

pablonyx commented Jun 12, 2025

Uh oh!

vercel bot commented Jun 12, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

greptile-apps bot Jun 12, 2025

Uh oh!

pablonyx commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		# Increase client body size for file uploads
		client_max_body_size 100M;

		"builder": "DOCKERFILE",
		"dockerfilePath": "deployment/docker_compose/docker-compose.railway.yml"

Feat/render previews #4885

Feat/render previews #4885

Uh oh!

Conversation

pablonyx commented Jun 12, 2025

Description

How Has This Been Tested?

Backporting (check the box to trigger backport action)

Uh oh!

vercel bot commented Jun 12, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

pablonyx commented Jun 12, 2025

🚀 Updated Render Preview Configuration

Changes Made:

⚠️ Required Setup:

How It Works:

Resources:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants