Skip to content

feat(p2p/dns): parse dns provided in CLI for p2p listeners #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
theochap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(p2p/dns): parse dns provided in CLI for p2p listeners #3197

theochap wants to merge 1 commit into from

Conversation

@theochap
Copy link
Member

@theochap theochap commented Dec 16, 2025

Description

Add support for input DNS(es) for p2p listener ips. Useful for docker context

Copilot AI review requested due to automatic review settings December 16, 2025 08:55
Copilot AI reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.1%. Comparing base (86910c9) to head (22c3605).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (86910c9) and HEAD (22c3605). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (86910c9) HEAD (22c3605)
proof 7 0
e2e 11 0
unit 2 1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emhane
emhane reviewed Dec 16, 2025
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the his should be referred to as DNS resolution since it never contacts a DNS server. the docs for to_socket_addrs says that it queries the OS for ip addresses (of named interfaces).

op-will
op-will approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@op-will op-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emhane emhane emhane left review comments

Copilot code review Copilot Copilot left review comments

@op-will op-will op-will approved these changes

@BioMark3r BioMark3r Awaiting requested review from BioMark3r BioMark3r is a code owner

@einar-oplabs einar-oplabs Awaiting requested review from einar-oplabs einar-oplabs is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theochap @emhane @op-will