Skip to content

[Enhance]: Support some detection models exportable to onnx #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hellock merged 9 commits into from
Nov 24, 2020
Merged

[Enhance]: Support some detection models exportable to onnx #4087

hellock merged 9 commits into from
Nov 24, 2020

Conversation

@RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Nov 11, 2020

  1. Support retinanet, ssd, fsaf and faster-rcnn exportable to onnx.
  2. Add visualization to pytorch2onnx tool.
  3. Modify batch_nms to be exportable to onnx.

@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #4087 (6d002d5) into master (01f1d42) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
- Coverage   61.80%   61.78%   -0.03%     
==========================================
  Files         225      225              
  Lines       16649    16697      +48     
  Branches     2818     2830      +12     
==========================================
+ Hits        10290    10316      +26     
- Misses       5859     5873      +14     
- Partials      500      508       +8
Flag Coverage Δ
unittests 61.73% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/coder/tblr_bbox_coder.py 20.33% <0.00%> (ø)
mmdet/core/export/pytorch2onnx.py 22.22% <0.00%> (-1.04%) ⬇️
mmdet/models/dense_heads/yolo_head.py 34.04% <0.00%> (ø)
mmdet/models/detectors/base.py 49.62% <0.00%> (-1.15%) ⬇️
mmdet/models/roi_heads/cascade_roi_head.py 70.61% <0.00%> (-0.59%) ⬇️
mmdet/models/roi_heads/standard_roi_head.py 64.44% <0.00%> (-2.48%) ⬇️
mmdet/models/roi_heads/mask_heads/fcn_mask_head.py 71.77% <10.00%> (-4.20%) ⬇️
mmdet/apis/inference.py 20.00% <25.00%> (-0.49%) ⬇️
...heads/roi_extractors/single_level_roi_extractor.py 65.95% <33.33%> (-17.38%) ⬇️
mmdet/models/roi_heads/test_mixins.py 54.26% <33.33%> (-5.57%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f1d42...6ad796d. Read the comment docs.

@RunningLeon RunningLeon requested a review from ZwwWayne November 13, 2020 09:29
ZwwWayne
ZwwWayne reviewed Nov 17, 2020
View reviewed changes
@hellock hellock merged commit 63772c5 into open-mmlab:master Nov 24, 2020
@RunningLeon RunningLeon deleted the dev_convert branch November 30, 2020 03:16
@xvjiarui xvjiarui mentioned this pull request Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RunningLeon @ZwwWayne @hellock