Skip to content

Conversation

@sanbuphy
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

I replaced the old api with the new one

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne changed the base branch from 3.x to dev-3.x October 28, 2022 02:10
@ZwwWayne ZwwWayne requested a review from wanghonglie October 28, 2022 02:12
@ZwwWayne
Copy link
Collaborator

Hi @sanbuphy ,
Thanks for your kind contribution. It seems that the results of each block are cleaned. It would be better to run these block once and keep the results in the notebook so that readers could have an expectation about the block outputs.

@ZwwWayne ZwwWayne added this to the 3.0.0rc3 milestone Oct 28, 2022
@sanbuphy
Copy link
Contributor Author

Hi @sanbuphy , Thanks for your kind contribution. It seems that the results of each block are cleaned. It would be better to run these block once and keep the results in the notebook so that readers could have an expectation about the block outputs.

OK, I will modify the results.

@ZwwWayne ZwwWayne mentioned this pull request Oct 28, 2022
@ZwwWayne ZwwWayne merged commit 816637e into open-mmlab:dev-3.x Oct 28, 2022
@sanbuphy sanbuphy deleted the 3.x branch November 24, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants