Skip to content

Conversation

@lihua199710
Copy link
Contributor

…talling pre-commit

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

According to mmcv's instructions to install pre-commit, we need .pre-commit-config-zh-cn.yaml. And mmdetection doesn't have provide this file yet. So i borrow this file from mmyolo to fix it.

Modification

This .pre-commit-config-zh-cn.yaml file is borrowed from mmyolo, and i only modified line 54 - line 56 to fit into mmdetection.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 27, 2022
@ZwwWayne ZwwWayne requested a review from hhaAndroid November 27, 2022 11:29
@ZwwWayne ZwwWayne merged commit 15c759c into open-mmlab:dev-3.x Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants