Skip to content

Add ResNeSt backbone #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZwwWayne merged 47 commits into from
Nov 24, 2020
Merged

Add ResNeSt backbone #2959

ZwwWayne merged 47 commits into from
Nov 24, 2020

Conversation

@xvjiarui
Copy link
Collaborator

@xvjiarui xvjiarui commented Jun 9, 2020

No description provided.

@xvjiarui xvjiarui added the WIP Working in progress label Jun 9, 2020
@hellock hellock mentioned this pull request Jun 9, 2020
Open
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #2959 (1b69331) into master (d7f4198) will increase coverage by 0.18%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2959      +/-   ##
==========================================
+ Coverage   61.84%   62.02%   +0.18%     
==========================================
  Files         225      226       +1     
  Lines       16672    16804     +132     
  Branches     2825     2839      +14     
==========================================
+ Hits        10310    10423     +113     
- Misses       5858     5866       +8     
- Partials      504      515      +11
Flag Coverage Δ
unittests 61.98% <84.21%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/backbones/resnest.py 83.96% <83.96%> (ø)
mmdet/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmdet/models/utils/res_layer.py 100.00% <100.00%> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.86% <0.00%> (-1.92%) ⬇️
mmdet/models/roi_heads/test_mixins.py 59.82% <0.00%> (+9.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f4198...eecef27. Read the comment docs.

@cpboost
Copy link

cpboost commented Aug 8, 2020

resnest能够带来全面的模型提升，使用官方版本的resnest在1.x修改使用在各个竞赛的使用上都有很棒的效果

@xvjiarui xvjiarui marked this pull request as draft September 26, 2020 02:48
@zhanghang1989 zhanghang1989 mentioned this pull request Nov 19, 2020
Closed
@xvjiarui xvjiarui removed the WIP Working in progress label Nov 21, 2020
@xvjiarui xvjiarui marked this pull request as ready for review November 21, 2020 19:32
@xvjiarui xvjiarui requested a review from hellock November 21, 2020 19:32
ZwwWayne
ZwwWayne reviewed Nov 22, 2020
View reviewed changes
@xvjiarui xvjiarui requested a review from ZwwWayne November 23, 2020 20:29
ZwwWayne
ZwwWayne reviewed Nov 24, 2020
View reviewed changes
ZwwWayne
ZwwWayne reviewed Nov 24, 2020
View reviewed changes
ZwwWayne
ZwwWayne reviewed Nov 24, 2020
View reviewed changes
ZwwWayne
ZwwWayne approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@ZwwWayne ZwwWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. See whether @hellock has any comments.

@ZwwWayne ZwwWayne merged commit 0293aed into open-mmlab:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@hellock hellock Awaiting requested review from hellock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xvjiarui @cpboost @ZwwWayne