Add custom-defined hooks in train api #3395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Johnson-Wang
commented
Jul 24, 2020
- Allows users to define hooks in configs
- Reformatted.
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
- Coverage 57.97% 57.86% -0.12%
==========================================
Files 202 202
Lines 13491 13498 +7
Branches 2282 2284 +2
==========================================
- Hits 7822 7811 -11
- Misses 5310 5327 +17
- Partials 359 360 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hellock
reviewed
Jul 24, 2020
mmdet/apis/train.py
Outdated
| runner.register_hook(eval_hook(val_dataloader, **eval_cfg)) | ||
|
|
||
| # user-defined hooks | ||
| if cfg.get('hooks', None): |
Member
There was a problem hiding this comment.
Rename the field hooks to additional_hooks or custom_hooks?
hellock
approved these changes
Jul 24, 2020
hellock
added a commit
that referenced
this pull request
Jul 24, 2020
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
* Add hooks * change hooks to custom_hooks
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
…n-mmlab#3399) This reverts commit 17c0f8e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.