Skip to content

Conversation

@jonbakerfish
Copy link

Only filter data during training but not in testing. Because test data is not labeled.

Only filter data when training but not in testing. Because test data is not labeled.
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #3744 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   60.93%   60.92%   -0.02%     
==========================================
  Files         217      217              
  Lines       15374    15374              
  Branches     2628     2628              
==========================================
- Hits         9368     9366       -2     
- Misses       5537     5540       +3     
+ Partials      469      468       -1     
Flag Coverage Δ
#unittests 60.92% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/custom.py 51.42% <100.00%> (ø)
mmdet/datasets/xml_style.py 17.17% <0.00%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b1ef8...1e345a8. Read the comment docs.

@hellock hellock requested a review from ZwwWayne September 12, 2020 15:51
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Sep 16, 2020

Hi @jonbakerfish ,
This PR duplicates #3695. Could you check whether #3695 meets your need? If so, we will close this PR and try to merge #3685 ASAP.

@jonbakerfish
Copy link
Author

Yes, it did fix the bug. Thanks.

@OpenMMLab-Assistant003
Copy link

Hi @jonbakerfish!We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @jonbakerfish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants