[Feature] Best ckpt hook #3773
Merged
[Feature] Best ckpt hook #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
- Coverage 61.80% 61.73% -0.07%
==========================================
Files 225 225
Lines 16649 16714 +65
Branches 2818 2835 +17
==========================================
+ Hits 10290 10319 +29
- Misses 5859 5889 +30
- Partials 500 506 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
Task linked: CU-4bw21b best performance checkpoint hook |
Collaborator
Johnson-Wang
left a comment
There was a problem hiding this comment.
The EvaluationHook has its unittest now. Therefore it would be better to add one for save_best as well.
Collaborator
Johnson-Wang
left a comment
There was a problem hiding this comment.
It all seems fine to me now except eval_metric.py.
Johnson-Wang
approved these changes
Sep 24, 2020
hellock
reviewed
Sep 27, 2020
hellock
reviewed
Sep 27, 2020
hellock
reviewed
Sep 27, 2020
Member
|
ping @xvjiarui |
Closed
ZwwWayne
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.