Skip to content

[Enhance] faster image transpose using tensor instead of numpy array#1976

Merged
ly015 merged 1 commit into
open-mmlab:dev-1.xfrom
ly015:img-transpose
Feb 15, 2023
Merged

[Enhance] faster image transpose using tensor instead of numpy array#1976
ly015 merged 1 commit into
open-mmlab:dev-1.xfrom
ly015:img-transpose

Conversation

@ly015

@ly015 ly015 commented Feb 15, 2023

Copy link
Copy Markdown
Member

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 requested review from Ben-Louis and Tau-J February 15, 2023 07:09
@codecov

codecov Bot commented Feb 15, 2023

Copy link
Copy Markdown

Codecov Report

Base: 81.98% // Head: 81.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cb6070b) compared to base (82a0677).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cb6070b differs from pull request most recent head 64e2889. Consider uploading reports for the commit 64e2889 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           dev-1.x    #1976   +/-   ##
========================================
  Coverage    81.98%   81.98%           
========================================
  Files          210      210           
  Lines        12237    12236    -1     
  Branches      2079     2079           
========================================
  Hits         10032    10032           
+ Misses        1755     1754    -1     
  Partials       450      450
Flag Coverage Δ
unittests 81.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/transforms/formatting.py 82.08% <100.00%> (-0.27%) ⬇️
mmpose/datasets/transforms/common_transforms.py 85.21% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit bc67c00 into open-mmlab:dev-1.x Feb 15, 2023
@ly015 ly015 deleted the img-transpose branch February 15, 2023 07:25
ly015 added a commit to ly015/mmpose that referenced this pull request Feb 21, 2023
@ly015
faster image transpose using tensor (open-mmlab#1976)
0f33fb5
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@ly015
faster image transpose using tensor (open-mmlab#1976)
666c035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ben-Louis Ben-Louis Ben-Louis approved these changes

@Tau-J Tau-J Awaiting requested review from Tau-J

Assignees

@Ben-Louis Ben-Louis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ly015 @Ben-Louis