Skip to content

Fix a typo in README.md#197

Merged
zhouzaida merged 1 commit into
open-mmlab:mainfrom
hu-po:main
Jan 28, 2023
Merged

Fix a typo in README.md#197
zhouzaida merged 1 commit into
open-mmlab:mainfrom
hu-po:main

Conversation

@hu-po

@hu-po hu-po commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

The download function of the mim module uses a kwarg called dest_root which was likely previously named dest_dir. This PR updates the readme to reflect that.

BC-breaking (Optional)

No

Use cases (Optional)

NA

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida changed the title Fix typo in download api kwarg Fix a typo in README.md Jan 28, 2023
@zhouzaida zhouzaida merged commit 231ffc7 into open-mmlab:main Jan 28, 2023
@jason102811

jason102811 commented Apr 4, 2023

Copy link
Copy Markdown

Hi @hu-po ！First of all, we want to express our gratitude for your significant PR in the MIM. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hu-po @jason102811 @zhouzaida