Skip to content

feat: update the color of the remove button. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gene9831 merged 1 commit into from
Sep 4, 2025
Merged

feat: update the color of the remove button. #213

gene9831 merged 1 commit into from
Sep 4, 2025

Conversation

@SonyLeo
Copy link
Collaborator

@SonyLeo SonyLeo commented Sep 4, 2025 •
edited by coderabbitai bot
Loading

更改移除 mcp 按钮的图标色

Summary by CodeRabbit

  • Style
    • Updated the delete icon styling in the Plugin Card for installed plugins by adding a dedicated delete class and applying the error color theme, improving visual emphasis and consistency.
    • Purely presentational change; no functional behavior, interactions, or events were modified.

@coderabbitai
Copy link

coderabbitai bot commented Sep 4, 2025 •
edited
Loading

Walkthrough

Updated PluginCard.vue to add a delete CSS class to the delete icon and introduced a corresponding CSS rule to apply an error color. No functional or event-handling logic was modified.

Changes

Cohort / File(s) Summary of Changes
PluginCard delete icon styling
packages/components/src/mcp-server-picker/components/PluginCard.vue		 Added delete class to <IconDelete> and new CSS rule .common-icon.delete { color: var(--tr-color-error); }. No logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my ears at a crimson hue,
A tiny icon dons a bold new view.
Clicks may stay the same—hop hop, indeed—
But style now whispers “danger, take heed.”
Carrot in paw, I merge with glee—
A tidy tweak for UI harmony. 🥕✨

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 396a3b0 and 39d1926.

⛔ Files ignored due to path filters (1)
  • packages/svgs/src/assets/delete.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • packages/components/src/mcp-server-picker/components/PluginCard.vue (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: e2e-tests
🔇 Additional comments (2)
packages/components/src/mcp-server-picker/components/PluginCard.vue (2)

117-117: LGTM: delete icon now clearly communicates destructive action

Changing to <IconDelete class="common-icon delete" /> aligns with the visual intent and is straightforward.

410-412: Add fallback error color and apply deep SVG fill/stroke under .delete
Ensure the delete icon inherits the error color even if the SVG doesn’t use currentColor:

   &.delete {
-    color: var(--tr-color-error);
+    color: var(--tr-color-error, #f2303e);
+    :deep(svg) {
+      fill: currentColor;
+      stroke: currentColor;
+    }
   }
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gene9831 gene9831 merged commit bf8dbb0 into opentiny:develop Sep 4, 2025
1 check passed
@SonyLeo SonyLeo deleted the style/mcp-delete-icon branch September 11, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gene9831 gene9831 gene9831 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SonyLeo @gene9831