Skip to content

Conversation

@StigOlavsen
Copy link
Contributor

Currently only numbers 1-4 are allowed in the minor version number. Since Unity 6, also the number 0 is used (6000.0). This commit changes the regex for the minor version number to include any number, which fixes support for Unity 6 and is more permissive in case any other numbers are used by Unity in the future.

Currently only numbers 1-4 are allowed in the minor version number.
Since Unity 6, also the number 0 is used (6000.0). This commit
changes the regex for the minor version number to include any number,
which fixes support for Unity 6 and is more permissive in case any
other numbers are used by Unity in the future.
@StigOlavsen StigOlavsen mentioned this pull request Aug 24, 2025
Copy link
Member

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTB.

@favoyang favoyang merged commit 6ad6837 into openupm:master Aug 25, 2025
github-actions bot pushed a commit that referenced this pull request Aug 25, 2025
## [4.5.2](4.5.1...4.5.2) (2025-08-25)

### Bug Fixes

* Allow any number for minor version number ([#423](#423)) ([6ad6837](6ad6837))
favoyang added a commit that referenced this pull request Aug 25, 2025
This commit introduces a new test case to validate the parsing of the editor version format 6000.x.y.zfn, ensuring that the parser correctly extracts the major, minor, patch, flag, and build components.

Refs #418 #423
@favoyang
Copy link
Member

@all-contributors please add @StigOlavsen for code.

@allcontributors
Copy link
Contributor

@favoyang

I've put up a pull request to add @StigOlavsen! 🎉

@StigOlavsen StigOlavsen deleted the fix-parse-editor-version branch August 25, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants