Fix: fix crash when add property maybe failed on build arguments #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer: quickjs-ng
We encountered a large number of online crashes, all of which were caused by insufficient memory when calling build arguments, resulting in the add_property call failing and returning null.
So I think there should be a judgment here instead of just letting it crash.
Thread
Scudo ERROR: internal map failure (NO MEMORY) requesting 4KB
pid: 0, tid: 6963 >>> com.xxx.dev <<<
backtrace:
#00 pc 0x00000000000c4bfc /data/app/~~xxx/lib/arm64/libquickjs.so
quickjs-ng/quickjs#1 pc 0x0000000000064cd0 /data/app/~~xxx/lib/arm64/libquickjs.so
quickjs-ng/quickjs#2 pc 0x0000000000065694 /data/app/~~xxx/lib/arm64/libquickjs.so
...
xxx arm64-v8a % aarch64-linux-android-addr2line -C -f -e libquickjs.so 0x00000000000c4bfc
js_build_arguments
xxx/quickjs.c:13574